Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDA w/operator component cleanups #1251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Nov 19, 2024

What does this PR do?

  • Remove hardcoded values such as namespace and operator image path in agentwithoperatorparams and operatorparams
  • Move KubernetesObjectRef to the kubernetes component
  • Add KubernetesObjectRef to the operator component output

Which scenarios this will impact?

Motivation

Additional Notes

components/datadog/agent/kubernetes_operator.go Outdated Show resolved Hide resolved
components/datadog/apps/dda/datadogagent.go Outdated Show resolved Hide resolved
@@ -11,7 +11,7 @@ import (
)

// OperatorOutput is used to import the Operator component
type OperatorOutput struct {
type OperatorOutput struct { // nolint:revive, We want to keep the name as <Component>Output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the lint error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants